Update for warehouse world #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roni-kreinin
requested changes
May 2, 2023
| # Subscribe to the /battery_state topic | ||
| self.battery_state_subscriber = self.create_subscription( | ||
| BatteryState, | ||
| '/battery_state', |
Contributor
There was a problem hiding this comment.
Don't use global namespace here.
| sleep(15) | ||
| with lock: | ||
| battery_percent = battery_monitor.battery_percent | ||
| print(f'Battery is at {(battery_percent*100):.2f}% charge', end='\r') |
Contributor
There was a problem hiding this comment.
Use navigator.info instead of print.
roni-kreinin
reviewed
May 2, 2023
|
|
||
| from operator import itemgetter | ||
|
|
||
| from pick import pick |
Contributor
There was a problem hiding this comment.
This is not a default python3 package. Let's avoid it and use input() instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated all examples for positions that work in the warehouse world and added 2 examples:
Patrol example: Drives in a loop forever while monitoring battery charge. If the battery charge goes low then it will return to the base to charge.
Mail delivery example: Has a list of possible endpoints that are able to be selected from the user interface. The robot will be sent to the selected location.
Type of change
How Has This Been Tested?
Each tutorial was launched and run in the warehouse world.
Checklist
The documentation update has been drafted but is pending this code review.